Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal color auto-detection no longer working with mintty (git-bash) #5724

Closed
aloucks opened this issue Jul 14, 2018 · 2 comments · Fixed by rust-lang/rust#52621
Closed

Comments

@aloucks
Copy link

aloucks commented Jul 14, 2018

Color auto-detection isn't working for mintty (git-bash) shells. Running with --color always or using winpty does show color correctly. Powershell and cmd.exe seem to work fine as well.

image

Color detection was working fine until I just updated via rustup. The issue is not present in beta.

image

@ehuss
Copy link
Contributor

ehuss commented Jul 14, 2018

Looks like the update to the winapi crate in the rust repo broke tty detection. I have posted a fix at softprops/atty#28. If that goes through, we'll need to wait for a new release, and then bump the lock file in the rust repo.

@alexcrichton
Copy link
Member

Thanks for tracking this down @ehuss!

kennytm added a commit to kennytm/rust that referenced this issue Jul 24, 2018
Fix color detection for Windows msys terminals.

Updates atty to pull in the fix softprops/atty#28.  Closes rust-lang/cargo#5724.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants