Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hamcrest to 0.1.1 - license clarification #3181

Closed
semarie opened this issue Oct 8, 2016 · 2 comments
Closed

bump hamcrest to 0.1.1 - license clarification #3181

semarie opened this issue Oct 8, 2016 · 2 comments

Comments

@semarie
Copy link
Contributor

semarie commented Oct 8, 2016

Hi,

I wonder if hamcrest could easily be bumped to 0.1.1 ?

Currently, cargo use hamcrest-0.1.0 (dev-dependency). This particular version has some licenses issues:

  • cartes.io reports it as MIT
  • but published 0.1.0 crate doesn't contains any license information

Some months ago, hamcrest has officially switched to Apache2/MIT (see ujh/hamcrest-rust#22), and some days ago a 0.1.1 has been published with updated license (see ujh/hamcrest-rust#40).

Updating to 0.1.1 would permit a more easy distribution of prerequistes for cargo.

As example, the current status for OpenBSD is the following (from http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/devel/cargo/Makefile?rev=1.4&content-type=text/x-cvsweb-markup):

# cargo is dual licensed MIT/Apache-2.0
# third-parties (detail below):
#  - MIT
#  - Unlicense/MIT
#  - MIT/Apache-2.0
#  - MPL-2.0
#  - one with no indication of licence (hamcrest)
#
# hamcrest is used only for the testsuite, and isn't builded with cargo.
# so the package doesn't contain it.
#
PERMIT_PACKAGE_CDROM = Yes
PERMIT_DISTFILES_FTP = No as hamcrest has no license information

we are unable to distribute source archives for cargo due to hamcrest dependency (cargo and dependencies are considere as a whole). Hopefully, binary-package is possible as hamcrest isn't builded with cargo (only used for testing).

Having cargo to depends to properly licensied dependencies would simplify the whole.

Thanks.

@steveklabnik
Copy link
Member

#3174 is updating some dependencies, but not this one. It shouldn't be difficult.

@alexcrichton
Copy link
Member

Sure! Want to send a PR to update?

bors added a commit that referenced this issue Oct 10, 2016
bump hamcrest to 0.1.1

update hamcrest to 0.1.1 and its dependencies.

Closes: #3181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants