Error on build script output without leading cargo that is not utf-8 #2556
Comments
ghost
mentioned this issue
|
See https://users.rust-lang.org/t/encoding-problem-of-cmake-path-on-windows/5333 for the initial issue. |
|
Oh dear, seems like a bad failure mode! |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this issue
Apr 11, 2016
Build scripts often stream output of native build systems like cmake/make and those aren't always guaranteed to produce utf-8 output. For example German MSVC cmake build has been reported to print non-utf-8 umlauts. This commit instead only attempts to interpret each line as utf-8 rather than the entire build script output. All non-utf-8 output is ignored. Closes rust-lang#2556
bors
added a commit
that referenced
this issue
Apr 20, 2016
Don't require all build script output to be utf-8 Build scripts often stream output of native build systems like cmake/make and those aren't always guaranteed to produce utf-8 output. For example German MSVC cmake build has been reported to print non-utf-8 umlauts. This commit instead only attempts to interpret each line as utf-8 rather than the entire build script output. All non-utf-8 output is ignored. Closes #2556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cargo's documentation of build scripts state that output beginning with
cargo:is interpreted. Other lines, however, are not completely ignored as non-utf-8 characters there cause the build to fail.An example where the build fails is using a build script with cmake on Windows with a german MSVC. While compiling a C library, the german output includes umlauts that are not utf-8. Even though the lines starting with
cargo:contain only utf-8, the build fails.The text was updated successfully, but these errors were encountered: