Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing liburl with rust-url #204

Closed
SimonSapin opened this issue Jul 15, 2014 · 1 comment · Fixed by #297
Closed

Replacing liburl with rust-url #204

SimonSapin opened this issue Jul 15, 2014 · 1 comment · Fixed by #297

Comments

@SimonSapin
Copy link
Contributor

Cargo currently uses the url crate distributed with rustc. As it has a number of issues, I rewrote it as rust-url, based on http://url.spec.whatwg.org/ , and I’m pushing to have it replaced in the rustc distribution:

rust-lang/rust#10707
https://github.com/SimonSapin/rust-url

Please let me know how I can help, such as what needs to change in rust-url for Cargo to use it. I suspect you’ll at least want an API to override is_relative_scheme to include the git and ssh schemes, but there’s probably more.

rust-url itself builds with Cargo right now, which could make bootstraping "interesting". But a Makefile like in Servo should work around that.
@alexcrichton
Copy link
Member

I believe that we may try bootstrapping ourselves once we get a lock file implemented. We've otherwise got all the tools we need (I believe) to bootstrap, so hopefully we'll just use cargo to install!

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 30, 2014
@alexcrichton
Migrate from liburl to rust-url
5c12868 
The standard url library is soon-to-be deprecated, and now that we're
bootstrapping it's trivial to move over to rust-url.

Closes rust-lang#204
@alexcrichton alexcrichton mentioned this issue Jul 30, 2014
Merged
bors added a commit that referenced this issue Jul 30, 2014
@bors
auto merge of #297 : alexcrichton/cargo/url, r=wycats
d0cd2fc 
The standard url library is soon-to-be deprecated, and now that we're
bootstrapping it's trivial to move over to rust-url.

Closes #204
@bors bors closed this as completed in #297 Jul 30, 2014
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@alexcrichton
Migrate from liburl to rust-url
f664874 
The standard url library is soon-to-be deprecated, and now that we're
bootstrapping it's trivial to move over to rust-url.

Closes rust-lang#204
bors added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@bors
auto merge of rust-lang#297 : alexcrichton/cargo/url, r=wycats
96e7412 
The standard url library is soon-to-be deprecated, and now that we're
bootstrapping it's trivial to move over to rust-url.

Closes rust-lang#204
ehuss pushed a commit to ehuss/cargo that referenced this issue Nov 19, 2023
@Manishearth
Merge pull request rust-lang#204 from calebcartwright/latest-cargo-fmt
0886aef 
use new cargo fmt option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from liburl to rust-url alexcrichton/cargo
2 participants
@alexcrichton @SimonSapin