Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented short keyword: '_' when Cargo.toml under path starting with _ #14379

Closed
jemtucker opened this issue Aug 9, 2024 · 2 comments · Fixed by #14380
Closed

Unimplemented short keyword: '_' when Cargo.toml under path starting with _ #14379

jemtucker opened this issue Aug 9, 2024 · 2 comments · Fixed by #14380
Labels
A-git Area: anything dealing with git C-bug Category: bug regression-from-stable-to-stable Regression in stable that worked in a previous stable release. S-triage Status: This issue is waiting on initial triage. Z-gitoxide Nightly: gitoxide integration

Comments

@jemtucker
Copy link
Contributor

Problem

Since rust-1.79 we have been unable to build packages that include build.rs within our rust workspace with cargo due to the following error.

error: failed to determine package fingerprint for build script for foo v0.1.0 (/Users/jemtucker/src/mvp/_code/rust/foo)

Caused by:
  failed to determine the most recently modified file in /Users/jemtucker/src/mvp/_code/rust/foo

Caused by:
  failed to determine list of files in /Users/jemtucker/src/mvp/_code/rust/foo

Caused by:
  Unimplemented short keyword: '_'

Our directory structure is as follows.

.git/...
_code/rust/Cargo.toml
_code/rust/foo/Cargo.toml
_code/rust/foo/build.rs
_code/rust/foo/src/lib.rs

This error occurs when gitoxide is attempting to parse pathspecs of the form :/_code/rust and :!/_code/rust which are invalid.

The fix is to use the non-shorthand pathspec keywords e.g. :(top)_code/rust.

Steps

No response

Possible Solution(s)

No response

Notes

No response

Version

No response

@jemtucker jemtucker added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Aug 9, 2024
@epage epage added A-git Area: anything dealing with git Z-gitoxide Nightly: gitoxide integration labels Aug 9, 2024
@epage
Copy link
Contributor

epage commented Aug 9, 2024

FYI @Byron

@Byron
Copy link
Member

Byron commented Aug 9, 2024

Thanks for posting and thanks so much for researching the fix!
I should have known that the shorthand notation is ambiguous and can't be used safely with an unknown path portion.

jemtucker added a commit to jemtucker/cargo that referenced this issue Aug 10, 2024
jemtucker added a commit to jemtucker/cargo that referenced this issue Aug 10, 2024
@epage epage added the regression-from-stable-to-stable Regression in stable that worked in a previous stable release. label Aug 12, 2024
@bors bors closed this as completed in 7ac34d3 Aug 12, 2024
antoniospg pushed a commit to antoniospg/cargo that referenced this issue Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-git Area: anything dealing with git C-bug Category: bug regression-from-stable-to-stable Regression in stable that worked in a previous stable release. S-triage Status: This issue is waiting on initial triage. Z-gitoxide Nightly: gitoxide integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants