Skip to content

Commit

Permalink
Auto merge of #5395 - dwijnand:contributing-setup-cross-tests, r=alex…
Browse files Browse the repository at this point in the history
…crichton

add contributing notes for cross compile test setup

adding notes from @alexcrichton's help in https://gitter.im/rust-lang/cargo?at=5ada2eae2b9dfdbc3ab01f29.
  • Loading branch information
bors committed Apr 20, 2018
2 parents db90cfe + e21f5b4 commit c85d6f3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ in `test/` provide templates on how to test Cargo's behavior in a
sandbox-environment. The internal crate `cargotest` provides a vast amount
of helpers to minimize boilerplate.
* Make sure `cargo test` passes. If you do not have the cross-compilers
installed locally, ignore the cross-compile test failures or disable them by
installed locally, install them using the instructions returned by
`cargo test cross_compile::cross_tests` (twice, with `--toolchain nightly`
added to get the nightly cross target too); alternatively just
ignore the cross-compile test failures or disable them by
using `CFG_DISABLE_CROSS_TESTS=1 cargo test`. Note that some tests are enabled
only on `nightly` toolchain. If you can, test both toolchains.
* All code changes are expected to comply with the formatting suggested by `rustfmt`.
Expand Down

0 comments on commit c85d6f3

Please sign in to comment.