Skip to content

Commit

Permalink
Make edition comparing code consistent
Browse files Browse the repository at this point in the history
Rather than sometimes comparing equality, sometimes using ordering and
sometimes pattern matching, consistently compare by equalty to 2015.
  • Loading branch information
dwijnand committed Dec 17, 2018
1 parent ff7f2bc commit b765fad
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
11 changes: 6 additions & 5 deletions src/cargo/ops/cargo_install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,19 +228,20 @@ fn install_one(
let pkg = ws.current()?;

if from_cwd {
match pkg.manifest().edition() {
Edition::Edition2015 => config.shell().warn(
if pkg.manifest().edition() == Edition::Edition2015 {
config.shell().warn(
"Using `cargo install` to install the binaries for the \
package in current working directory is deprecated, \
use `cargo install --path .` instead. \
Use `cargo build` if you want to simply build the package.",
)?,
Edition::Edition2018 => failure::bail!(
)?
} else {
failure::bail!(
"Using `cargo install` to install the binaries for the \
package in current working directory is no longer supported, \
use `cargo install --path .` instead. \
Use `cargo build` if you want to simply build the package."
),
)
}
};

Expand Down
12 changes: 6 additions & 6 deletions src/cargo/util/toml/targets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ fn clean_lib(
(None, Some(path)) => path,
(None, None) => {
let legacy_path = package_root.join("src").join(format!("{}.rs", lib.name()));
if edition < Edition::Edition2018 && legacy_path.exists() {
if edition == Edition::Edition2015 && legacy_path.exists() {
warnings.push(format!(
"path `{}` was erroneously implicitly accepted for library `{}`,\n\
please rename the file to `src/lib.rs` or set lib.path in Cargo.toml",
Expand Down Expand Up @@ -661,9 +661,8 @@ fn toml_targets_and_inferred(

let autodiscover = match autodiscover {
Some(autodiscover) => autodiscover,
None => match edition {
Edition::Edition2018 => true,
Edition::Edition2015 => {
None =>
if edition == Edition::Edition2015 {
if !rem_targets.is_empty() {
let mut rem_targets_str = String::new();
for t in rem_targets.iter() {
Expand Down Expand Up @@ -694,8 +693,9 @@ https://github.com/rust-lang/cargo/issues/5330",
));
};
false
} else {
true
}
},
};

if autodiscover {
Expand Down Expand Up @@ -805,7 +805,7 @@ fn target_path(
match (first, second) {
(Some(path), None) => Ok(path),
(None, None) | (Some(_), Some(_)) => {
if edition < Edition::Edition2018 {
if edition == Edition::Edition2015 {
if let Some(path) = legacy_path(target) {
return Ok(path);
}
Expand Down

0 comments on commit b765fad

Please sign in to comment.