Skip to content

Commit

Permalink
Bump to 0.59.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ehuss committed Oct 22, 2021
1 parent 7fbbf4e commit 8811750
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 46 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "cargo"
version = "0.58.0"
version = "0.59.0"
edition = "2018"
authors = ["Yehuda Katz <wycats@gmail.com>",
"Carl Lerche <me@carllerche.com>",
Expand Down
9 changes: 0 additions & 9 deletions src/cargo/core/compiler/build_context/target_info.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ pub struct TargetInfo {
pub rustdocflags: Vec<String>,
/// Whether or not rustc supports the `-Csplit-debuginfo` flag.
pub supports_split_debuginfo: bool,
/// Whether or not rustc supports the `--force-warn` flag. Remove after 1.56 is stable.
pub supports_force_warn: bool,
}

/// Kind of each file generated by a Unit, part of `FileType`.
Expand Down Expand Up @@ -180,12 +178,6 @@ impl TargetInfo {
extra_fingerprint,
)
.is_ok();
let supports_force_warn = rustc
.cached_output(
process.clone().arg("--force-warn=rust-2021-compatibility"),
extra_fingerprint,
)
.is_ok();

process.arg("--print=sysroot");
process.arg("--print=cfg");
Expand Down Expand Up @@ -261,7 +253,6 @@ impl TargetInfo {
)?,
cfg,
supports_split_debuginfo,
supports_force_warn,
})
}

Expand Down
24 changes: 4 additions & 20 deletions src/cargo/ops/fix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ use rustfix::diagnostics::Diagnostic;
use rustfix::{self, CodeFix};
use semver::Version;

use crate::core::compiler::{CompileKind, RustcTargetData, TargetInfo};
use crate::core::compiler::RustcTargetData;
use crate::core::resolver::features::{DiffMap, FeatureOpts, FeatureResolver};
use crate::core::resolver::{HasDevUnits, Resolve, ResolveBehavior};
use crate::core::{Edition, MaybePackage, PackageId, Workspace};
Expand All @@ -68,7 +68,6 @@ const FIX_ENV: &str = "__CARGO_FIX_PLZ";
const BROKEN_CODE_ENV: &str = "__CARGO_FIX_BROKEN_CODE";
const EDITION_ENV: &str = "__CARGO_FIX_EDITION";
const IDIOMS_ENV: &str = "__CARGO_FIX_IDIOMS";
const SUPPORTS_FORCE_WARN: &str = "__CARGO_SUPPORTS_FORCE_WARN";

pub struct FixOptions {
pub edition: bool,
Expand Down Expand Up @@ -124,17 +123,6 @@ pub fn fix(ws: &Workspace<'_>, opts: &mut FixOptions) -> CargoResult<()> {
let rustc = ws.config().load_global_rustc(Some(ws))?;
wrapper.arg(&rustc.path);

// Remove this once 1.56 is stabilized.
let target_info = TargetInfo::new(
ws.config(),
&opts.compile_opts.build_config.requested_kinds,
&rustc,
CompileKind::Host,
)?;
if target_info.supports_force_warn {
wrapper.env(SUPPORTS_FORCE_WARN, "1");
}

// primary crates are compiled using a cargo subprocess to do extra work of applying fixes and
// repeating build until there are no more changes to be applied
opts.compile_opts.build_config.primary_unit_rustc = Some(wrapper);
Expand Down Expand Up @@ -849,7 +837,7 @@ impl FixArgs {
fn apply(&self, cmd: &mut Command) {
cmd.arg(&self.file);
cmd.args(&self.other);
if self.prepare_for_edition.is_some() && env::var_os(SUPPORTS_FORCE_WARN).is_some() {
if self.prepare_for_edition.is_some() {
// When migrating an edition, we don't want to fix other lints as
// they can sometimes add suggestions that fail to apply, causing
// the entire migration to fail. But those lints aren't needed to
Expand All @@ -868,12 +856,8 @@ impl FixArgs {

if let Some(edition) = self.prepare_for_edition {
if edition.supports_compat_lint() {
if env::var_os(SUPPORTS_FORCE_WARN).is_some() {
cmd.arg("--force-warn")
.arg(format!("rust-{}-compatibility", edition));
} else {
cmd.arg("-W").arg(format!("rust-{}-compatibility", edition));
}
cmd.arg("--force-warn")
.arg(format!("rust-{}-compatibility", edition));
}
}
}
Expand Down
12 changes: 0 additions & 12 deletions tests/testsuite/fix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -950,10 +950,6 @@ fn prepare_for_already_on_latest_unstable() {
#[cargo_test]
fn prepare_for_already_on_latest_stable() {
// Stable counterpart of prepare_for_already_on_latest_unstable.
if !is_nightly() {
// Remove once 1.56 is stabilized.
return;
}
if Edition::LATEST_UNSTABLE.is_some() {
eprintln!("This test cannot run while the latest edition is unstable, skipping.");
return;
Expand Down Expand Up @@ -1528,10 +1524,6 @@ fn rustfix_handles_multi_spans() {
#[cargo_test]
fn fix_edition_2021() {
// Can migrate 2021, even when lints are allowed.
if !is_nightly() {
// Remove once 1.56 is stabilized.
return;
}
let p = project()
.file(
"Cargo.toml",
Expand Down Expand Up @@ -1748,10 +1740,6 @@ fn fix_with_run_cargo_in_proc_macros() {
#[cargo_test]
fn non_edition_lint_migration() {
// Migrating to a new edition where a non-edition lint causes problems.
if !is_nightly() {
// Remove once force-warn hits stable.
return;
}
let p = project()
.file("Cargo.toml", &basic_manifest("foo", "0.1.0"))
.file(
Expand Down
4 changes: 0 additions & 4 deletions tests/testsuite/new.rs
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,6 @@ fn new_with_reference_link() {

#[cargo_test]
fn lockfile_constant_during_new() {
if !cargo_test_support::is_nightly() {
// Remove when 1.56 is stable (cargo new defaults to 2021).
return;
}
cargo_process("new foo").run();

cargo_process("build").cwd(&paths::root().join("foo")).run();
Expand Down

0 comments on commit 8811750

Please sign in to comment.