refactor: clean some duplicate code.

rust-lang · Feb 21, 2025 · 7735088 · 7735088
1 parent 6e93991
commit 7735088
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/cargo/ops/cargo_compile/unit_generator.rs b/src/cargo/ops/cargo_compile/unit_generator.rs
@@ -286,8 +286,8 @@ impl<'a> UnitGenerator<'a, '_> {
                 }
             };
 
+            let mut msg = String::new();
             if !suggestion.is_empty() {
-                let mut msg = String::new();
                 writeln!(
                     msg,
                     "no {} target {} `{}`{}",
@@ -297,10 +297,7 @@ impl<'a> UnitGenerator<'a, '_> {
                     suggestion
                 )?;
                 append_targets_elsewhere(&mut msg)?;
-
-                anyhow::bail!(msg);
             } else {
-                let mut msg = String::new();
                 writeln!(
                     msg,
                     "no {} target {} `{}`.",
@@ -315,8 +312,8 @@ impl<'a> UnitGenerator<'a, '_> {
                         writeln!(msg, "    {}", target.name())?;
                     }
                 }
-                anyhow::bail!(msg);
             }
+            anyhow::bail!(msg);
         }
         Ok(proposals)
     }