Skip to content

Commit

Permalink
Auto merge of #6267 - ehuss:fix-fix_path_deps-again, r=alexcrichton
Browse files Browse the repository at this point in the history
Fix fix_path_deps again.

The previous fix in #6236 wasn't enough to make this test not fail. On Travis MacOS it fails about 5% of the time. Essentially the first "FIXING" line is sometimes delayed until after the second "CHECKING" line. The "FIXING" message is sent async to the diagnostic server, so I think it's just a race that doesn't have a good way to enforce.  Oddly, I can only repro this on Travis.

Error seen at:
https://travis-ci.org/rust-lang/cargo/jobs/450956693
  • Loading branch information
bors committed Nov 6, 2018
2 parents f938c4f + 89413bd commit 0eee76e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/testsuite/fix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ fn fix_path_deps() {
p.cargo("fix --allow-no-vcs -p foo -p bar")
.env("__CARGO_FIX_YOLO", "1")
.with_stdout("")
.with_stderr(
.with_stderr_unordered(
"\
[CHECKING] bar v0.1.0 ([..])
[FIXING] bar/src/lib.rs (1 fix)
Expand Down

0 comments on commit 0eee76e

Please sign in to comment.