Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Remove duplicated output of RegressOn variant names from the help #229

Merged
merged 1 commit into from
Oct 12, 2022
Merged

cli: Remove duplicated output of RegressOn variant names from the help #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,27 +326,27 @@ enum RegressOn {
/// case for when you want to bisect to see when a bug was fixed.
Success,

/// `Ice`: Marks test outcome as `Regressed` if and only if the `rustc`
/// Marks test outcome as `Regressed` if and only if the `rustc`
/// process issues a diagnostic indicating that an internal compiler error
/// (ICE) occurred. This covers the use case for when you want to bisect to
/// see when an ICE was introduced pon a codebase that is meant to produce
/// a clean error.
Ice,

/// `NonIce`: Marks test outcome as `Regressed` if and only if the `rustc`
/// Marks test outcome as `Regressed` if and only if the `rustc`
/// process does not issue a diagnostic indicating that an internal
/// compiler error (ICE) occurred. This covers the use case for when you
/// want to bisect to see when an ICE was fixed.
NonIce,

/// `NonError`: Marks test outcome as `Baseline` if and only if the `rustc`
/// Marks test outcome as `Baseline` if and only if the `rustc`
/// process reports error status and does not issue any diagnostic
/// indicating that an internal compiler error (ICE) occurred. This is the
/// use case if the regression is a case where an ill-formed program has
/// stopped being properly rejected by the compiler.
/// (The main difference between this case and `Success` is the handling of
/// ICE: `Success` assumes that ICE should be considered baseline;
/// `NonError` assumes ICE should be considered a sign of a regression.)
/// (The main difference between this case and `success` is the handling of
/// ICE: `success` assumes that ICE should be considered baseline;
/// `non-error` assumes ICE should be considered a sign of a regression.)
NonError,
}

Expand Down
28 changes: 14 additions & 14 deletions tests/cmd/help.stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,22 +66,22 @@ Options:
program. This covers the use case for when you want to bisect to see when a bug was
fixed
- ice:
`Ice`: Marks test outcome as `Regressed` if and only if the `rustc` process issues a
diagnostic indicating that an internal compiler error (ICE) occurred. This covers the
use case for when you want to bisect to see when an ICE was introduced pon a codebase
that is meant to produce a clean error
Marks test outcome as `Regressed` if and only if the `rustc` process issues a diagnostic
indicating that an internal compiler error (ICE) occurred. This covers the use case for
when you want to bisect to see when an ICE was introduced pon a codebase that is meant
to produce a clean error
- non-ice:
`NonIce`: Marks test outcome as `Regressed` if and only if the `rustc` process does not
issue a diagnostic indicating that an internal compiler error (ICE) occurred. This
covers the use case for when you want to bisect to see when an ICE was fixed
Marks test outcome as `Regressed` if and only if the `rustc` process does not issue a
diagnostic indicating that an internal compiler error (ICE) occurred. This covers the
use case for when you want to bisect to see when an ICE was fixed
- non-error:
`NonError`: Marks test outcome as `Baseline` if and only if the `rustc` process reports
error status and does not issue any diagnostic indicating that an internal compiler
error (ICE) occurred. This is the use case if the regression is a case where an
ill-formed program has stopped being properly rejected by the compiler. (The main
difference between this case and `Success` is the handling of ICE: `Success` assumes
that ICE should be considered baseline; `NonError` assumes ICE should be considered a
sign of a regression.)
Marks test outcome as `Baseline` if and only if the `rustc` process reports error status
and does not issue any diagnostic indicating that an internal compiler error (ICE)
occurred. This is the use case if the regression is a case where an ill-formed program
has stopped being properly rejected by the compiler. (The main difference between this
case and `success` is the handling of ICE: `success` assumes that ICE should be
considered baseline; `non-error` assumes ICE should be considered a sign of a
regression.)

--script <SCRIPT>
Script replacement for `cargo build` command
Expand Down