Use git CLI to fetch a repo. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
camelid
reviewed
Oct 2, 2021
| eprintln!("refreshing repository at {:?}", repo); | ||
| // This uses the CLI because libgit2 is quite slow to fetch a large repository. | ||
| let status = std::process::Command::new("git") | ||
| .arg("fetch") |
There was a problem hiding this comment.
I think this needs to use something like the old repo.remote_anonymous(RUST_SRC_URL). E.g., if I run git fetch in my rust-lang/rust clone, it only fetches my fork, which doesn't have the latest changes.
There was a problem hiding this comment.
Good point! I normally point it at a repo where origin is rust-lang/rust, but it makes sense to use the correct remote. I don't think it can use an anonymous remote (since that is in memory only), but I added the URL to the fetch line which should do the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the git fetch of the rust-lang/rust repo to use the
gitCLI command instead of libgit2. This is because libgit2 has some performance issues with large repos. On my system, a fetch that is not particularly old takes about 4 minutes with libgit2, whereas with the git CLI it takes about 2 seconds.