Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo bisect-rustc Fails While cargo-bisect-rustc Works. #186

Closed
Alexhuszagh opened this issue Aug 4, 2022 · 0 comments · Fixed by #187
Closed

cargo bisect-rustc Fails While cargo-bisect-rustc Works. #186

Alexhuszagh opened this issue Aug 4, 2022 · 0 comments · Fixed by #187

Comments

@Alexhuszagh
Copy link

Alexhuszagh commented Aug 4, 2022 •
edited
Loading

Issue

Running the following currently seems to fail:

$  cargo bisect-rustc --help
error: Found argument 'bisect-rustc' which wasn't expected, or isn't valid in this context

USAGE:
    cargo-bisect-rustc.exe [OPTIONS] [-- <COMMAND_ARGS>...]

For more information try --help

However, invoking cargo-bisect-rustc directly does work:

$ cargo-bisect-rustc --help
Bisects rustc toolchains with rustup

USAGE:
    cargo-bisect-rustc.exe [OPTIONS] [-- <COMMAND_ARGS>...]

ARGS:
    <COMMAND_ARGS>...    Arguments to pass to cargo or the file specified by --script during
                         tests

OPTIONS:
    -a, --alt                       Download the alt build instead of normal build
...

This seems to be related to #46.

Version Info

  • cargo: 1.61.0 (a028ae42f 2022-04-29)
  • cargo-bisect-rustc 0.6.4

Bisect

The failing commit is b0ac34c, which changed to proper clap functions rather than structop. This fails on Windows and Linux.
@Alexhuszagh Alexhuszagh changed the title cargo bisect-rustc cargo bisect-rustc fails while cargo-bisect-rustc works Aug 4, 2022
@Alexhuszagh Alexhuszagh changed the title cargo bisect-rustc fails while cargo-bisect-rustc works cargo bisect-rustc Fails While cargo-bisect-rustc Works. Aug 4, 2022
@Emilgardis Emilgardis mentioned this issue Aug 4, 2022
Merged
@Alexhuszagh Alexhuszagh mentioned this issue Aug 8, 2022
Merged
bors bot added a commit to cross-rs/cross that referenced this issue Aug 8, 2022
@bors @Alexhuszagh
Merge #992
e0d77d1 
992: Fix cargo-bisect-rustc issues during CI. r=Emilgardis a=Alexhuszagh

Works around rust-lang/cargo-bisect-rustc#186.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow usage of cargo bisect-rustc and cargo-bisect-rustc Emilgardis/cargo-bisect-rustc
1 participant
@Alexhuszagh