Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch12 edits #576

Merged
merged 6 commits into from
Mar 29, 2017
Merged

Ch12 edits #576

merged 6 commits into from
Mar 29, 2017

Conversation

carols10cents
Copy link
Member

Replaces #563. I'd love reviews from anyone!

Fixes #532, #418, and #378.

Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 👍

which Chapters XX, YY, and ZZ respectively are about to cover in detail.

Let's create a new project with, as always, `cargo new`:
# An I/O Project Using Environment Variables and Standard Error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something that says more about what we're doing? "build a grep".

This title is okay but kinda... boring?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "An I/O Project Implementing a Grep Clone"
  • "An I/O Project Implementing a Command Line Program"
  • "An I/O Project Building a Small Grep"

??? Imma sleep on it 💤

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like "An I/O Project Building a Small Grep" best, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

<!-- Public domain Emily Dickinson poem. This will work best with something
short, but that has multiple lines and some repetition. We could search through
code; that gets a bit meta and possibly confusing... Changes to this are most
welcome. /Carol -->
<!-- :D I like it! I'm all for keeping -->
<!-- Great! /Carol -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@carols10cents carols10cents merged commit b1c4de2 into master Mar 29, 2017
@carols10cents carols10cents deleted the ch12-edits branch March 29, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants