Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ch18-03: Guarded match arm exhaustivness clarification" #3894

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions src/ch18-03-pattern-syntax.md
Original file line number Diff line number Diff line change
Expand Up @@ -477,27 +477,8 @@ second arm doesn’t have a match guard and therefore matches any `Some` variant

There is no way to express the `if x % 2 == 0` condition within a pattern, so
the match guard gives us the ability to express this logic. The downside of
this additional expressiveness is that the compiler is not smart enough about
arms exhaustiveness anymore when match guard expressions are involved.

```rust,ignore,does_not_compile
match Some(100) {
Some(_) if true => print!("Got Some"),
None => print!("Got None")
}
```
This `match` expression involves compilation error.
```console
error[E0004]: non-exhaustive patterns: `Some(_)` not covered
--> src/main.rs:33:11
|
33 | match Some(100) {
| ^^^^^^^^^ pattern `Some(_)` not covered
|
```
Compilation fails even though `Some(_) if true` guarded pattern matches
any possible `Some`. Same as unguarded `Some(_)` does.

this additional expressiveness is that the compiler doesn't try to check for
exhaustiveness when match guard expressions are involved.

In Listing 18-11, we mentioned that we could use match guards to solve our
pattern-shadowing problem. Recall that we created a new variable inside the
Expand Down