clarify discussion of macros and namspaces #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated, travis failed due to accidentally having lost |
The existing text was rather unclear, for instance it might mislead a person into the false understanding that ALL macros within a crate are exported, regardless of export attribute (which is not mentioned). If the text is going to make references to namespace differences compared to functions and bringing them into scope and such, we might as well have something clear and truly informative.
|
Thank you for your work! However, Rust 1.30 has changed the way macros are exported and imported, so this section needs to be redone in light of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing text was rather unclear, for instance it might mislead a
person into the false understanding that ALL macros within a crate are
exported, regardless of export attribute (which is not mentioned).
If the text is going to make references to namespace differences
compared to functions and bringing them into scope and such, we might as
well have something clear and truly informative.