[Ch08-03: Hash maps] Description of program doesn't match the actual code #3251
Milestone
Comments
|
You're totally right, I messed up! Fixed now, thank you!!! |
|
Mistakes happen, we're only humans. :) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jul 5, 2022
Update books ## nomicon 2 commits in 3a43983b76174342b7dbd3e12ea2c49f762e52be..70db9e4189f64d1d8e2451b1046111fb356b6dc2 2022-05-30 17:01:30 +0900 to 2022-06-27 20:47:21 +0900 - should be `size_of` instead of `align_of` (rust-lang/nomicon#371) - Fix wording on the aliasing section (rust-lang/nomicon#366) ## book 20 commits in efbafdba3618487fbc9305318fcab9775132ac15..cf2653a5ca553cbbb4a17f1a7db1947820f6a775 2022-06-19 21:06:50 -0400 to 2022-07-05 12:07:58 -0400 - Frontmatter - Update to Rust 1.62 - Extract where clause example so it'll get rustfmtted in the future - Merge remote-tracking branch 'origin/pr/3238' into extract-where-clause-example - Fix line wrapping of lib placement fix - Fix grammar, spelling, and line wrapping of description of appendices - Merge remote-tracking branch 'origin/pr/3244' into binlib - Clarify *type* parameter names - Fix listing 8-21. Fixes rust-lang/book#3251 - Propagate tech review changes for ch13 - Responses to tech review of chapter 13 - Tech review comments on chapter 13 - Fix double the - Propagate tech review chapter 1 changes to src - Address tech review comments for chapter 1 - Tech review comments for chapter 1 - Fix grammar - Fix grammar - Edits to edits to the introduction - Comments from nostarch on the introduction ## rust-by-example 8 commits in 1095df2a5850f2d345fad43a30633133365875ba..83724ca387a2a1cd3e8d848f62820020760e358b 2022-06-18 21:47:12 -0300 to 2022-07-05 10:38:07 -0300 - changing names of params (rust-lang/rust-by-example#1567) - Update incorrect print output in std/box.md (rust-lang/rust-by-example#1564) - minor typo (rust-lang/rust-by-example#1563) - fix: Fibonacci sequence starts from zero (rust-lang/rust-by-example#1562) - add Vietnamese version on README.md (rust-lang/rust-by-example#1561) - Update variadics.md (rust-lang/rust-by-example#1559) - Change fold to sum in fn hof.md (rust-lang/rust-by-example#1560) - Small typo, fixed compileable -> compilable (rust-lang/rust-by-example#1556) ## rustc-dev-guide 8 commits in 048d925f0a955aac601c4160c0e7f05771bcf63b..eb83839e903a0a8f1406f7e941886273f189b26b 2022-06-21 22:25:34 +0900 to 2022-07-03 15:17:39 +0900 - Suggest a separate build directory for rust-analyzer (rust-lang/rustc-dev-guide#1378) - Change the old filename, "src/stage0.txt" to "src/stage0.json" (rust-lang/rustc-dev-guide#1383) - Add the config needed to get rust-analyzer working on src/bootstrap (rust-lang/rustc-dev-guide#1381) - Fix path to hir_id_validator.rs - leave formatOnSave to the user (rust-lang/rustc-dev-guide#1380) - diagnostics: structs with new slug syntax (rust-lang/rustc-dev-guide#1377) - Few readability fixes - humorust: Forbid pineapple on pizza (rust-lang/rustc-dev-guide#1374) ## embedded-book 1 commits in e17dcef5e96346ee3d7fa56820ddc7e5c39636bc..766979590da8100998f0d662499d4a901d8d1640 2022-06-19 10:28:00 +0000 to 2022-07-04 09:13:58 +0000 - "linker `link.exe` not found" fix (rust-embedded/book#321)
|
I also noticed this and did a review before opening an issue. I found that the solution was already done but just FYI the live version of the book still shows the old version of the code.
|
|
The book rides the Rust release trains. The fix is live at https://doc.rust-lang.org/beta/book/ch08-03-hash-maps.html (note the "beta" in the URL) and will be fixed on stable with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mainbranch to see if this has already been fixedURL to the section(s) of the book with this problem:
https://github.com/rust-lang/book/blob/main/src/ch08-03-hash-maps.md?plain=1#L60
https://github.com/rust-lang/book/blob/main/listings/ch08-common-collections/listing-08-21/src/main.rs
Description of the problem:
I'm new to Rust so maybe I'm misunderstanding something, but the book says this about listing 8-21:
Yet the code listing that it's referring to doesn't use
unwrap_or.Suggested fix:
Either implement what the text says, or remove the text.
The text was updated successfully, but these errors were encountered: