-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edition 2021 blog post #825
Conversation
In the |
I don't think so. This is not the edition guide; just an overview. I only very quickly mention the existence of non-string panics, which are rather uncommon. Edit: Added a small note now. |
Hm, I'm seeing a contradiction in the text:
and later it says:
Did you mean to say Also I find it strange that |
@therealprof That snippet describes the current situation, before Rust 1.53.
Starting in 1.53, we will have that trait implementation and
|
@m-ou-se Thanks for pointing out how bad of a reader I am. 😅 After a few more passes I can parse that correctly, so 👍 from me. I'd still change
to
so the important difference stands out a bit clearer. |
I purposely put that |
ddf701b
to
824cb36
Compare
Fair enough, what about |
That does the opposite. That will add a reference, giving you for ref e in &[1, 2, 3] {
let _: i32 = **e;
} |
I guess I really need to shut up and hide in a dark place now to read up on the syntax quirks and automatic derefencing. 😅 Thanks for the education. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pushing this out to May 10th or 11th would be good. By then I hope that we can have the primary edition RFC merged and the changes still in-flight (e.g., T-libs approval of prelude, token reservation RFC merged) also finished up.
3b31e80
to
2d07263
Compare
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
When reading rust-lang/rust#84147, I found it noteworthy that in particular
|
Sounds good. @rust-lang/core can y'all review it this week so we can publish it next Monday? |
@Mark-Simulacrum Can we get this merged and published today? :) |
I think let's go for tomorrow: it seems likely this wants good coverage, but today we're merging #836 and that'll likely distract from this. |
:D |
cc @rust-lang/project-edition-2021
Rendered
Closes rust-lang/rust#84593