Add post about using regression labels #706
Conversation
camelid
commented
Oct 8, 2020
•
camelid
commented
- Describe how to set regression labels
- Give some background on the issue that caused us to allow this
- Mention that you can use the new regression issue template
- Describe how to request prioritization of an issue
|
Cc @rust-lang/wg-prioritization |
|
I am wondering if we should make "report a regression" one of the GitHub issue templates, alongside this post, which tags the issue for triage to label appropriately, for example. |
|
Yes, I was thinking of suggesting that! I can open a PR. |
|
A regression template sounds like a great idea. And it'd have prompts for things like which version it worked on, so it'd also be helpful when we gets comments like rust-lang/rust#34162 (comment) |
|
Opened rust-lang/rust#77725! |
| Finally, if you have an issue that is *not* a regression, but is still something | ||
| that is important to be fixed, you can request prioritization with: |
There was a problem hiding this comment.
I would perhaps add a bit more to the part that encourages people to apply the prioritize label. From the user perspective, sometimes an issue might always be so.
I think we can help by providing generic guidelines / examples of what the prioritize label would be a good fit for. Off the top of my head:
- a new feature of rustc/rust lib crashes
- rustfmt crashes?
- weird long compile times (or is this more a regression?)
- ...
I must be a bit hand-wavy here because I kind of miss the right context for proper examples, so this suggestion might as well not be worth being explored 🐱
|
thumbs up for me, nice post @camelid 👍 |
|
Waiting on rust-lang/rust#77725. |
|
This is great!!! 👍 |
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
regression-labels
branch
from
9bdcc3b to
3f4f1d5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The PR this was blocked on was merged, so I'll update the post date, and then I think this is ready to merge! |
|
I can also squash if you want. |
|
@camelid please do |
camelid
force-pushed
the
regression-labels
branch
from
1b29ab8 to
8cacdb5
Compare
|
Done. Also updated date to tomorrow, since that's probably when this will be merged. |
| --- | ||
|
|
||
| If you've contributed to Rust before, you have likely used a command like this | ||
| to [set labels][rustbot-labeling-docs]: |
There was a problem hiding this comment.
I think we should avoid starting off like this. People who haven't used it might feel excluded. Plus, I think this post should actually be moved to the main blog: inside rust is targeted to contributors, but we want regular users to do this as well.
There was a problem hiding this comment.
I think we should avoid starting off like this. People who haven't used it might feel excluded.
That's a good point, I didn't think of that. Perhaps I'll go with something like "One of the ways we keep track of Rust issues is with labels, which you can modify using a command like this...". Or maybe it would make more sense to just skip this part?
Plus, I think this post should actually be moved to the main blog: inside rust is targeted to contributors, but we want regular users to do this as well.
Sounds good, I was thinking of suggesting that.
| regression labels on issues! This is all you have to do to mark an issue as a | ||
| regression and it will automatically be prioritized: | ||
|
|
||
| > **@rustbot** modify labels: regression-from-stable-to-{release-channel} |
There was a problem hiding this comment.
I think we should include regression-untriaged here as well, and perhaps only that. Regardless we should expand upon this to include that you should test on current stable and beta when reporting regressions so that we can appropriately categorize (i.e., the closest to stable should be chosen).
|
@Mark-Simulacrum I rewrote a bunch of it to hopefully make it more approachable and more inclusive to non-contributors. Let me know what you think! (EDIT: by the way, no rush! I just wanted to let you know :) ) |
|
Ok, I will merge this tomorrow morning (presuming I do not forget :) |
