-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a blog on changes to 128-bit integers #1281
Conversation
Made a few editorial changes. Otherwise, LGTM. I think this level of detail is great. |
e5f411a
to
c7564e2
Compare
Awesome, thanks Josh. I think I made all the changes you requested and did the adjustments I wanted to the last section, ready for another look when you get the chance. |
Ship it. :) I'm not an approver for blog.rust-lang.org, but 👍 with my lang hat on. Someone with approval permission for blog.rust-lang.org will need to do the merge. As a note: I think this is worth putting on blog.rust-lang.org rather than the Inside Rust blog, because it's a long-standing compatibility issue with some subtle compatibility details. I think we should draw people's attention to it. |
Woohoo 🎉 thanks again!
Is that something I need to change here? I thought this was the repo for the main blog. |
Cc @Mark-Simulacrum if you're around |
It looks like the lang team leads should be able to merge too,, cc @tmandry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge with date updated, just poke me on Zulip (github notifications are usually slower to process and easier to miss).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good post.
Fix the metadata block Co-authored-by: Josh Triplett <josh@joshtriplett.org> Add annotations to Clang's output of the example
As I mentioned in rust-lang/lang-team#255, I put together a blog about the alignment changes to
i128
/u128
in 1.77 and 1.78. I probably have some adjustments to make in the last two sections so I will mark this as a draft.I'm unsure if this background-heavy format suits the official blog of if something more concise is preferred, but I can make adjustments as needed.
@joshtriplett would likely be willing to give the lang team signoff once this is ready.
Cc @maurer @nikic @nagisa since you are all mentioned.