Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a blog on changes to 128-bit integers #1281

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

tgross35
Copy link
Contributor

As I mentioned in rust-lang/lang-team#255, I put together a blog about the alignment changes to i128/u128 in 1.77 and 1.78. I probably have some adjustments to make in the last two sections so I will mark this as a draft.

I'm unsure if this background-heavy format suits the official blog of if something more concise is preferred, but I can make adjustments as needed.

@joshtriplett would likely be willing to give the lang team signoff once this is ready.

Cc @maurer @nikic @nagisa since you are all mentioned.

@joshtriplett
Copy link
Member

Made a few editorial changes. Otherwise, LGTM. I think this level of detail is great.

@tgross35 tgross35 force-pushed the i128-blog branch 6 times, most recently from e5f411a to c7564e2 Compare March 25, 2024 05:56
@tgross35
Copy link
Contributor Author

Awesome, thanks Josh. I think I made all the changes you requested and did the adjustments I wanted to the last section, ready for another look when you get the chance.

@tgross35 tgross35 marked this pull request as ready for review March 25, 2024 05:59
@joshtriplett
Copy link
Member

Ship it. :)

I'm not an approver for blog.rust-lang.org, but 👍 with my lang hat on. Someone with approval permission for blog.rust-lang.org will need to do the merge.

As a note: I think this is worth putting on blog.rust-lang.org rather than the Inside Rust blog, because it's a long-standing compatibility issue with some subtle compatibility details. I think we should draw people's attention to it.

@tgross35
Copy link
Contributor Author

Ship it. :)

I'm not an approver for blog.rust-lang.org, but 👍 with my lang hat on. Someone with approval permission for blog.rust-lang.org will need to do the merge.

Woohoo 🎉 thanks again!

As a note: I think this is worth putting on blog.rust-lang.org rather than the Inside Rust blog, because it's a long-standing compatibility issue with some subtle compatibility details. I think we should draw people's attention to it.

Is that something I need to change here? I thought this was the repo for the main blog.

@tgross35
Copy link
Contributor Author

Cc @Mark-Simulacrum if you're around

@tgross35
Copy link
Contributor Author

It looks like the lang team leads should be able to merge too,, cc @tmandry

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge with date updated, just poke me on Zulip (github notifications are usually slower to process and easier to miss).

Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good post.

Fix the metadata block

Co-authored-by: Josh Triplett <josh@joshtriplett.org>

Add annotations to Clang's output of the example
@Mark-Simulacrum Mark-Simulacrum merged commit c254258 into rust-lang:master Mar 30, 2024
3 checks passed
@tgross35 tgross35 deleted the i128-blog branch March 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants