Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce major Generator -> Coroutine rename #1155

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 20, 2023

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok!

@the8472
Copy link
Member

the8472 commented Oct 21, 2023

Probably should mention that it's only relevant for nightly users.

@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 23, 2023

Updated. what do I need to do to publish this?

@Mark-Simulacrum
Copy link
Member

Currently date is set for tomorrow, I can merge then (ping me). Or happy to publish today, but then date should be updated.

@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 23, 2023

huh... I... should probably not be writing blog posts at 2am... not sure why I used the 24th.

@Mark-Simulacrum renamed the file to match today's date

@Mark-Simulacrum Mark-Simulacrum merged commit 1a64906 into rust-lang:master Oct 23, 2023
2 checks passed
@oli-obk oli-obk deleted the coroutines branch October 23, 2023 16:48
@jeffparsons
Copy link

huh... I... should probably not be writing blog posts at 2am... not sure why I used the 24th.

No, you definitely should, because this was super entertaining reading. Can you write all the Rust blog posts from now on? 😛

One question, though: you mentioned that generators are a convenient way to write iterators. Isn't there also a performance angle? For some reason I had the impression that the compiler-generated state machine would be faster than what, e.g., chain can do today. Is that actually true, or did I make that up?

@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 25, 2023

For a very simple chain I would think that it comes out as equivalent. We'll have to actually look at examples and codegen to see where we can improve things. In the end, we'll try to be zero cost where plausible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants