Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: correctly handle spaces in /proc/pid/maps pathnames #553

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Bug fix: correctly handle spaces in /proc/pid/maps pathnames #553

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f2e9f9
Corrects /proc/pid/maps parser to correctly handle spaces in pathnames
MasonRemaley Jul 24, 2023
047c2b3
Fixes copy paste error
MasonRemaley Jul 24, 2023
c017a00
Adds test for multiple continuous spaces
MasonRemaley Jul 24, 2023
ce72d89
Replaces most trims with trim_start
MasonRemaley Jul 24, 2023
aeb25db
Allows for paths with trailing spaces
MasonRemaley Jul 24, 2023
edad5f0
Update src/symbolize/gimli/parse_running_mmaps_unix.rs
MasonRemaley Jul 30, 2023
45aa13b
Update src/symbolize/gimli/parse_running_mmaps_unix.rs
MasonRemaley Jul 30, 2023
aa3186a
Update src/symbolize/gimli/parse_running_mmaps_unix.rs
MasonRemaley Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/symbolize/gimli/parse_running_mmaps_unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,4 +264,18 @@ fn check_maps_entry_parsing_32bit() {
pathname: "/executable/path/with some spaces".into(),
}
);
assert_eq!(
"b7c79000-b7e02000 r--p 00000000 08:01 60662705 \
/executable/path/with multiple-continues spaces "
MasonRemaley marked this conversation as resolved.
Show resolved Hide resolved
.parse::<MapsEntry>()
.unwrap(),
MapsEntry {
address: (0xb7c79000, 0xb7e02000),
perms: ['r', '-', '-', 'p'],
offset: 0x00000000,
dev: (0x08, 0x01),
inode: 0x60662705,
pathname: "/executable/path/with multiple-continues spaces".into(),
MasonRemaley marked this conversation as resolved.
Show resolved Hide resolved
}
);
}