-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std support #126
Add no_std support #126
Conversation
8ef7580
to
13371ce
Compare
I've fixed the problems on linux. The failures in the CI seem unrelated to the PR. |
Thanks for the PR! I fear though that the strategy of sprinkling
|
@alexcrichton Thanks for the feedback, I currently have a in development version that addresses most of this. However I wanted to ask you what kind of abstraction were you thinking for the |
I think Windows may be a stickler where the information is actually |
c9ee9b4
to
5a4f807
Compare
@alexcrichton Okay, I've updated the PR with your feedback. Please let know if there's anything else required! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think CI is still broken though?
4f5276e
to
eb1ebb4
Compare
ee00643
to
474c342
Compare
@alexcrichton Okay, I fixed everything wrong with the CI, and made changes in respect to your feedback. Let me know if there is anything else! |
I've been working through this but unfortunately ran out of time for the near future. I don't mind picking this up from here, but some things I've noticed are:
|
@alexcrichton I don't mind working on it. in relation to |
@Aaronepower oh that's probably because the test is quite brittle and some constants in there need to change, although if that doesn't get it passing I can help dig in too |
Also update the implementation to invoke the unsynchronized version
At the same time use fewer globs to ensure we're only working with `c_void`, no other types.
No need to activate that!
Ok I've pushed up all the changes that I think I'd like to see, now waiting on CI |
This is a renewed version of #50 for rust-lang/#39503.
cc @Mark-Simulacrum