Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate Slice origins and surrounding empty lines #34

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Removing duplicate Slice origins and surrounding empty lines #34

merged 2 commits into from
Jun 8, 2020

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented May 12, 2020

Closes #9
@phansch ??

@zzau13 zzau13 changed the title Fix unnecessary mutable at convert snippet::Slice Removing duplicate Slice origins and surrounding empty lines May 13, 2020
@zzau13
Copy link
Contributor Author

zzau13 commented Jun 8, 2020

I seems that the changes in Rust are finally going to merge rust-lang/rust#72026 (comment). And I would like to continue with this to adapt this crate and integrate it into rust. Does not appear @phansch . I will continue without him.

Can @zbraniecki review it, please?

@zbraniecki
Copy link
Contributor

Yes, thank you! It looks great!

@zbraniecki zbraniecki merged commit 26fb6e1 into rust-lang:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing duplicate Slice origins and surrounding empty lines
2 participants