Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.2.0 release #131

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Prepare for 1.2.0 release #131

merged 2 commits into from
Nov 4, 2018

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Nov 1, 2018

Current changeset

This release includes a change that bumps our minimum supported rustc version from 1.21.0 to 1.24.1 in order to solve a soundness issue (see #117 for details). This compiler version does seem to be readily available in package managers.

cc @Kimundi @eddyb @RalfJung

also cc @BurntSushi @jethrogb (who might be interested in the minimum version bump)

@KodrAus
Copy link
Contributor Author

KodrAus commented Nov 1, 2018

It looks like we could roll #130 in too.

@jethrogb
Copy link

jethrogb commented Nov 1, 2018

I appreciate the notification but I don't see what use it is, unless you're prepared to have this discussion about minimum Rust version all over again.

@KodrAus
Copy link
Contributor Author

KodrAus commented Nov 1, 2018

Yeh the ping was mostly out of courtesy. We wouldn't have bumped the minimum version if there was a sound way to fix #117 without it.

Oh since we've bumped past 1.22 we should be able to simplify/remove the build script now too.

@BurntSushi
Copy link
Member

BurntSushi commented Nov 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants