forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve invalid UTF-8 lint by finding the expression initializer
- Loading branch information
Showing
3 changed files
with
137 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,110 +1,167 @@ | ||
warning: calls to `std::str::from_utf8_unchecked_mut` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:19:9 | ||
--> $DIR/invalid_from_utf8.rs:21:9 | ||
| | ||
LL | std::str::from_utf8_unchecked_mut(&mut [99, 108, 130, 105, 112, 112, 121]); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/invalid_from_utf8.rs:4:9 | ||
--> $DIR/invalid_from_utf8.rs:6:9 | ||
| | ||
LL | #![warn(invalid_from_utf8_unchecked)] | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8_unchecked_mut` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:21:9 | ||
--> $DIR/invalid_from_utf8.rs:23:9 | ||
| | ||
LL | std::str::from_utf8_unchecked_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:39:9 | ||
--> $DIR/invalid_from_utf8.rs:41:9 | ||
| | ||
LL | std::str::from_utf8_unchecked(&[99, 108, 130, 105, 112, 112, 121]); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:41:9 | ||
--> $DIR/invalid_from_utf8.rs:43:9 | ||
| | ||
LL | std::str::from_utf8_unchecked(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:43:9 | ||
--> $DIR/invalid_from_utf8.rs:45:9 | ||
| | ||
LL | std::str::from_utf8_unchecked(b"cl\x82ippy"); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior | ||
--> $DIR/invalid_from_utf8.rs:45:9 | ||
--> $DIR/invalid_from_utf8.rs:47:9 | ||
| | ||
LL | std::str::from_utf8_unchecked(concat_bytes!(b"cl", b"\x82ippy")); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:62:9 | ||
--> $DIR/invalid_from_utf8.rs:64:9 | ||
| | ||
LL | std::str::from_utf8_mut(&mut [99, 108, 130, 105, 112, 112, 121]); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/invalid_from_utf8.rs:5:9 | ||
--> $DIR/invalid_from_utf8.rs:7:9 | ||
| | ||
LL | #![warn(invalid_from_utf8)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:64:9 | ||
--> $DIR/invalid_from_utf8.rs:66:9 | ||
| | ||
LL | std::str::from_utf8_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:82:9 | ||
--> $DIR/invalid_from_utf8.rs:84:9 | ||
| | ||
LL | std::str::from_utf8(&[99, 108, 130, 105, 112, 112, 121]); | ||
| ^^^^^^^^^^^^^^^^^^^^-----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^----------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:84:9 | ||
--> $DIR/invalid_from_utf8.rs:86:9 | ||
| | ||
LL | std::str::from_utf8(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']); | ||
| ^^^^^^^^^^^^^^^^^^^^----------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
| ^^^^^^^^^^^^^^^^^^^^^---------------------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:86:9 | ||
--> $DIR/invalid_from_utf8.rs:88:9 | ||
| | ||
LL | std::str::from_utf8(b"cl\x82ippy"); | ||
| ^^^^^^^^^^^^^^^^^^^^-------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:88:9 | ||
--> $DIR/invalid_from_utf8.rs:90:9 | ||
| | ||
LL | std::str::from_utf8(concat_bytes!(b"cl", b"\x82ippy")); | ||
| ^^^^^^^^^^^^^^^^^^^^---------------------------------^ | ||
| | | ||
| the literal was valid UTF-8 up to the 2 bytes | ||
|
||
warning: 12 warnings emitted | ||
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:97:5 | ||
| | ||
LL | let mut a = [99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8_mut(&mut a); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:101:5 | ||
| | ||
LL | let mut a = [99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
... | ||
LL | std::str::from_utf8_mut(c); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:104:5 | ||
| | ||
LL | let mut c = &[99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8(c); | ||
| ^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:107:5 | ||
| | ||
LL | const INVALID_1: [u8; 7] = [99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8(&INVALID_1); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:110:5 | ||
| | ||
LL | static INVALID_2: [u8; 7] = [99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8(&INVALID_2); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:113:5 | ||
| | ||
LL | const INVALID_3: &'static [u8; 7] = &[99, 108, 130, 105, 112, 112, 121]; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8(INVALID_3); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: calls to `std::str::from_utf8` with a invalid literal always return an error | ||
--> $DIR/invalid_from_utf8.rs:116:5 | ||
| | ||
LL | const INVALID_4: &'static [u8; 7] = { &[99, 108, 130, 105, 112, 112, 121] }; | ||
| ---------------------------------- the literal was valid UTF-8 up to the 2 bytes | ||
LL | std::str::from_utf8(INVALID_4); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: 19 warnings emitted | ||
|