Skip to content

Commit

Permalink
Unrolled build for rust-lang#114453
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#114453 - Kobzol:ci-group-stdout, r=onur-ozkan

Print GHA log groups to stdout instead of stderr

In all other places (e.g. `bootstrap.py`, `opt-dist`), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?).

r? `@ghost`
  • Loading branch information
rust-timer committed Oct 2, 2023
2 parents 8e47113 + 88b9985 commit 2a23084
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/tools/build_helper/src/ci.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ pub mod gha {

fn start_group(name: impl std::fmt::Display) {
if is_in_gha() {
eprintln!("::group::{name}");
println!("::group::{name}");
} else {
eprintln!("{name}")
println!("{name}")
}
}

fn end_group() {
if is_in_gha() {
eprintln!("::endgroup::");
println!("::endgroup::");
}
}

Expand Down

0 comments on commit 2a23084

Please sign in to comment.