Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ section in readme #31

Merged
merged 2 commits into from
Dec 1, 2021
Merged

FAQ section in readme #31

merged 2 commits into from
Dec 1, 2021

Conversation

lmammino
Copy link
Member

This PR adds a FAQ section in the README.

Right now this section has only 1 question that tries to answer to #30.

This is totally open for discussion. I am not strongly opinionated on this but I'd be in favour of having such explicit warning (mostly to raise awareness)

@lmammino lmammino requested a review from lu-zero November 29, 2021 14:46
@lmammino lmammino self-assigned this Nov 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #31 (8c524b3) into main (a447b92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files          10       10           
  Lines        1077     1077           
=======================================
  Hits          920      920           
  Misses        157      157           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a447b92...8c524b3. Read the comment docs.

Copy link
Collaborator

@nappa85 nappa85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't nothing smart to add to the topic, I hate legal stuff and related things.
Seems ok to me

@lmammino lmammino merged commit 1c767d0 into main Dec 1, 2021
@lmammino lmammino deleted the faq branch December 1, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants