Merge ASAN_OPTIONS instead of overwriting them #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuda
changed the title
This concatenates the "detect_odr_violation=0" option to existing ASAN_OPTIONS, instead of overwriting them, which allows users to pass their own ASAN_OPTIONS. One use case for this is limiting the fuzzing time by passing -max_total_time to libfuzzer: when the allowed time expires, the fuzzer will stop in the middle of a fuzzing target, and leak sanitizer will report an error, and exit with a nonzero exit code. Setting ASAN_OPTIONS="detect_leaks=0" works around this problem, but then cargo-fuzz must not overwrite those options. Concatenate them instead.
|
Build failure appears to be caused by rust-lang/cargo#3819. |
|
Thanks! bors r+ |
|
bors r+ |
ruuda
added a commit
to ruuda/claxon
that referenced
this pull request
Mar 14, 2017
This relies on my fix for ASAN_OPTIONS (concatenate user options, instead of overwriting them) landing in cargo-fuzz. See rust-fuzz/cargo-fuzz#84.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concatenates the
detect_odr_violation=0option to existingASAN_OPTIONS, instead of overwriting them, which allows users to pass their ownASAN_OPTIONS.One use case for this is limiting the fuzzing time by passing
-max_total_timeto libfuzzer: when the allowed time expires, the fuzzer will stop in the middle of a fuzzing target, and leak sanitizer will report an error, and exit with a nonzero exit code. SettingASAN_OPTIONS="detect_leaks=0"works around this problem, but thencargo-fuzzmust not overwrite those options. Concatenate them instead.