Fix broken OS detection #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another fix for broken RUSTFLAGS when this workaround is in effect. |
|
These seem like no-brainers no? Can they just be merged? |
The rust-fuzz#141 workaround was actually fully disabled because the OS condition was wrong. This fixes the workaround.
When the fix for rust-fuzz#141 is in effect if you pass extra RUSTFLAGS there is no space separating them and the command line breaks. Fix that by adding a space at the end of those flags, just like it's done in the common string.
pedrocr
force-pushed
the
fix-linux-platform-check
branch
from
94c1986 to
3b11385
Compare
frewsxcv
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #141 workaround was actually fully disabled because the OS condition
was wrong. This fixes the workaround.