little cleanups #845
Merged
little cleanups #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci diff pr |
Emilgardis
reviewed
Jun 1, 2024
src/generate/register.rs
Outdated
| method("read"), | ||
| if inmodule { "(R)" } else { "" }, | ||
| )?; | ||
|
|
||
| if let Some(action) = read_action { | ||
| doc.push_str("WARN: "); | ||
| doc.push_str(" WARN: "); |
There was a problem hiding this comment.
We could make this a little better with rust-lang/rust#106561 now :D
There was a problem hiding this comment.
It's interesting. I'll test. The question is should we up MSRV or not?
There was a problem hiding this comment.
since it's just css it doesn't break when the class doesn't exist. No msrv bump needed
There was a problem hiding this comment.
Seems like done.
Do you have any other ideas on improving documentation?
burrbull
force-pushed
the
clean
branch
3 times, most recently
from
01a2179
to
45b2a30
Compare
Emilgardis
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.