Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unused dependencies optional #118

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Make unused dependencies optional #118

merged 3 commits into from
Feb 7, 2025

Conversation

Ayush1325
Copy link
Contributor

  • I am working on some examples for PocketBeagle 2, and we have decided to use Rust for it.
  • Since it is a constrained device, it would be best to have minimal dependencies. To that end, I will be disabling default-features in most single peripheral examples.
  • However, currently some dependencies are pulled even with the default features disabled, so I would prefer it if they were also behind a selectable feature instead.

@Ayush1325
Add serial feature
c9692e1 
- No need to pull serialport-rs and embedded-hal-nb in projects that do
  not need serial functionality.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325 Ayush1325 requested a review from a team as a code owner February 4, 2025 13:18
eldruin
eldruin reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!
Could you also add an entry to the changelog?

@Ayush1325
Make nix optional
fb2db21 
- nix dependency is only directly used for i2c in this crate.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Add Changelong entry for rust-embedded#118
17b2457 
Signed-off-by: Ayush Singh <ayush@beagleboard.org>
eldruin
eldruin approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin added this pull request to the merge queue Feb 7, 2025
Merged via the queue into rust-embedded:master with commit 1ffb268 Feb 7, 2025
8 checks passed
@Ayush1325 Ayush1325 deleted the serial-optional branch February 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayush1325 @eldruin