Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump embedded-hal to rc 3 #105

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Bump embedded-hal to rc 3 #105

merged 3 commits into from
Dec 20, 2023

Conversation

tommy-gilligan
Copy link
Contributor

No description provided.

@tommy-gilligan tommy-gilligan requested a review from a team as a code owner December 18, 2023 00:35
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you update the changelog as well?

@tommy-gilligan
Copy link
Contributor Author

I updated the changelog. I think it maybe makes sense to squash the eh update lines but I didn't want to presume (so no squashing unless you say so)

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please do squash them.

@tommy-gilligan
Copy link
Contributor Author

Looks like a transient network failure on CI

@eldruin
Copy link
Member

eldruin commented Dec 20, 2023

Hmm, could you add sudo apt-get update to the CI here like this?:

run: |
    sudo apt-get update
    sudo apt-get install -y libc6-armhf-cross libc6-dev-armhf-cross gcc-arm-linux-gnueabihf

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin added this pull request to the merge queue Dec 20, 2023
Merged via the queue into rust-embedded:master with commit a1fb241 Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants