Fix compiler warnings (requires rustc 1.36.0). #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem::unitialized() is deprecated, use mem::MaybeUninit instead which exists since rustc 1.36.0.
|
Okay, so apparently there is a minimum rust version specified. Should the corresponding change just be dropped? |
|
Wouldn't it be better to have a moving compatibility policy where major releases support the N most recent rust versions? |
|
Apparently, the dependencies of the examples already require rustc 1.40 or newer - or at least that is how I'd interpret that CI failure. |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2020
35: RFC: Line event stream support for Tokio r=posborne a=mgottschlag The second commit (on top of #34 for my convenience, but completely independent) adds support for asynchronous handling of line events/interrupts based on Tokio. This patch probably fixes #18 . This probably needs some further discussion: * I set the Rust edition to 2018 to be able to use `async`/`await` in the example. * The API is just a light wrapper around `LineEventHandle`. I implemented `AsRef<LineEventHandle>` instead of adding a separate `get_value()` function. Do we want a function to destroy an `AsyncLineEventHandle` and get the original `LineEventHandle` back? * I placed the type in an `async_tokio` module and behind an `async_tokio` feature flag, under the expectation that one day there might be wrapper types for other async I/O frameworks (async_std?) as well. Co-authored-by: Mathias Gottschlag <mgottschlag@gmail.com> Co-authored-by: Paul Osborne <osbpau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem::unitialized() is deprecated, use mem::MaybeUninit instead which exists
since rustc 1.36.0.
The documentation needed to be pulled into the macro, I verified that locally the correct documentation is generated.
I don't know what your policy regarding the minimum rustc version is (or if you have one).