Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port code to the 2018 edition #1

Closed
japaric opened this issue Aug 2, 2018 · 0 comments · Fixed by #19
Closed

Port code to the 2018 edition #1

japaric opened this issue Aug 2, 2018 · 0 comments · Fixed by #19
Assignees
@japaric
Labels
Blocks Rust 2018 help wanted Extra attention is needed
Milestone
2018

Comments

@japaric
Copy link
Member

japaric commented Aug 2, 2018

All the code snippets must be using 2018 edition features and must compile on 1.30-beta by RC1.
@japaric japaric added this to the RC1 milestone Aug 2, 2018
@japaric japaric self-assigned this Aug 7, 2018
@japaric japaric added the help wanted Extra attention is needed label Aug 17, 2018
japaric added a commit that referenced this issue Sep 5, 2018
@japaric
move code to the 2018 edition
cbec54e 
closes #1
@japaric japaric mentioned this issue Sep 5, 2018
Merged
japaric added a commit that referenced this issue Sep 14, 2018
@japaric
move code to the 2018 edition
b917d64 
closes #1
bors bot added a commit that referenced this issue Sep 14, 2018
@bors @japaric
Merge #19
7861c4a 
19: move code to the 2018 edition r=japaric a=japaric

most code changes are minor

the annoying part of using the 2018 edition right now is that there is no easy
way to create new 2018 project (Cargo still defaults to 2015 projects; see
rust-lang/cargo#5980) and there's no visible documentation on how to move a new
project to the 2018 edition (see rust-lang/edition-guide#102) so I have
included the required changes in the preface -- I hope people won't miss that
part.

r? @rust-embedded/resources (anyone)

closes #1

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors bors bot closed this as completed in #19 Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@japaric japaric

Labels
Blocks Rust 2018 help wanted Extra attention is needed
Projects
None yet
Milestone
2018
Development

Successfully merging a pull request may close this issue.

move code to the 2018 edition rust-embedded/embedonomicon
1 participant
@japaric