-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rust-version field #490
Conversation
The 1.60 MSRV is due to the use of Options:
I'm not sure what's the best solution here. |
Yeah, that is a valid concern. However,
I'm fine with making it more granular per crate.
Well, I'm unsurprisingly in favor of this approach. It is machine-readable, generates clear error messages instead of some issues, which seem totally unrelated for the user, if they did not check their installed version yet, and it can be better checked by CI. The README approach is not as visible to most users and has to be verified manually if the MSRV needs changing. IMO But this is not up to me, as I'm not a maintainer of embedded-hal, so I'm fine if you close this PR and keep using the current approach. :) |
FYI: if you want to identify the MSRV for each crate (to set it now initially) you can use cargo-msrv to do that. i think with that it's then also no hassle to update it for the individual crates when needed |
cd667e6
to
689408b
Compare
I've reduced the MSRV for all crates, which do not use |
i think this should land before v1.0 is released - it'd help with cleaner error messages in the future when the MSRV for a crate is increased. the rust/crates teams also encourages setting this field (see various posts in their forums & issues) |
Doing option 2 ("Track MSRV for each crate individually, set rust-version to that.") sounds good to me then. We can discuss it next weekly meeting and merge if there's no objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in today's meeting, conclusion is track MSRV per crate separately.
Async stuff will have to be rust-version = 1.75
.
I'll add CI to test the different MSRVs in a follow-up PR.
I've noticed that this project does not use the
rust-version
field yet, while maintaining a MSRV policy. Add this field to makethis policy machine-readable and leverage nicer cargo feedback in case of an older rust version.