Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release embedded-hal-async v0.1.0-alpha.3 #423

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Oct 26, 2022

Fixes compliation on latest nightlies, so we'd like to get this out soon.

I've named the version 0.1.0 and not 0.1.0-alpha.3 because there's not much point in using the alpha if the main version is 0.1 which already indicates "API is WIP". Next breaking change can be released as v0.2 (probably the switch to AFIT), etc.

@Dirbaio Dirbaio requested a review from a team as a code owner October 26, 2022 10:16
@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

@eldruin
Copy link
Member

eldruin commented Oct 26, 2022

Another rationale for the -alpha version is the dependency on an -alpha version of embedded-hal.
For this crate I am fine with either, though.
Do you want to go ahead with 0.1.0?

@Dirbaio Dirbaio force-pushed the release-eha-v0.1.0 branch from fbce1dc to f2033d3 Compare October 26, 2022 13:40
@Dirbaio
Copy link
Member Author

Dirbaio commented Oct 26, 2022

Another rationale for the -alpha version is the dependency on an -alpha version of embedded-hal.

Oh... I didn't think about that at all. 🤣 That's not semver-stable at all, indeed.

-alpha.3 it is then.

@Dirbaio Dirbaio changed the title Release embedded-hal-async v0.1.0 Release embedded-hal-async v0.1.0-alpha.3 Oct 26, 2022
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
bors r+

@bors bors bot merged commit 9eb6dab into master Oct 26, 2022
@bors bors bot deleted the release-eha-v0.1.0 branch October 26, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants