map asm! ops to unimplemented! on non ARM targets #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homunkulus r+ |
|
📌 Commit f79f4b7 has been approved by |
japaric
pushed a commit
that referenced
this pull request
Dec 23, 2017
map asm! ops to unimplemented! on non ARM targets closes #63 cc @hannobraun
|
☀️ Test successful - status-travis |
Merged
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
81: Add a __pre_init function to be called at the start of the reset handler r=korken89 a=yodaldevoid I needed this for a project so I went ahead and rebased and tweaked @jcsoo 's changes from #71. I will admit, I got a little impatient waiting and that also played into why I did this. If either @jcsoo or @japaric have an issue with this PR, please let me know and I will remove it. I apologize for toes that I have stepped on. Now onto the PR. This is possibly the simplest implementation that is possible. No nightly features were used in this implementation. Also, there is no hand-holding for the end user; if they want to mess with uninitialized statics, that is on them. If you would like me to add more documentation, please let me know what you would like to see. Fixes #17 Co-authored-by: Jonathan Soo <jcsoo@agora.com> Co-authored-by: Gabriel Smith <ga29smith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63
cc @hannobraun