Merge HStdout and HStderr into the same type #41
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I like this change but it is a breaking change so would require a 0.4 release. |
They were exactly the same anyway. Now it is easier to pass either stdout or stderr to a function, for example.
This commit copies rust-embedded/cortex-m-semihosting#41 into the cortex-m repository.
269: Merge HStdout and HStderr into the same type r=jonas-schievink a=adamgreig As the next step in #263 (review), this PR applies rust-embedded/cortex-m-semihosting#41 to this repository. @m-ou-se, I tried exporting a patch from cortex-m-semihosting and applying it here but it didn't work first time, so I ended up just copying the changes. I've set you as the author of the commit and marked it as committed-by me, I hope you're OK with that but please let me know if you'd like it changed. (Also, thanks again for the PR, sorry it's taken over a year...). Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
|
This is now merged in rust-embedded/cortex-m#269, the new location of this crate. |
They were exactly the same anyway. Now it is easier to pass either
stdout or stderr to a function, for example.