Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no concrete artifact was specified pick the default #55

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

therealprof
Copy link
Contributor

Signed-off-by: Daniel Egger daniel@eggers-club.de

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof therealprof requested a review from a team as a code owner April 8, 2020 20:50
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@therealprof therealprof changed the title If nothing no concrete artifact was specified pick the default If no concrete artifact was specified pick the default Apr 8, 2020
@therealprof
Copy link
Contributor Author

therealprof commented Apr 8, 2020

Fixes #39

@@ -328,7 +326,7 @@ To see all the flags the proxied tool accepts run `cargo-{} -- -help`.{}",
cargo.args(&["--lib", lib_name]);
lib_name
} else {
unreachable!();
""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the other paths resolve to a &str, too and I didn't want to change the type to an Option and make the additional changes to all the other places using it.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems worth having right now but at some point this lib could probably use a bit of a tidyup as you mentioned.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 8, 2020

Build succeeded

@bors bors bot merged commit 81de50f into rust-embedded:master Apr 8, 2020
@therealprof therealprof deleted the pick-default-target branch April 9, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants