-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If no concrete artifact was specified pick the default #55
Conversation
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Fixes #39 |
@@ -328,7 +326,7 @@ To see all the flags the proxied tool accepts run `cargo-{} -- -help`.{}", | |||
cargo.args(&["--lib", lib_name]); | |||
lib_name | |||
} else { | |||
unreachable!(); | |||
"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not None
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the other paths resolve to a &str
, too and I didn't want to change the type to an Option
and make the additional changes to all the other places using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems worth having right now but at some point this lib could probably use a bit of a tidyup as you mentioned.
bors r+
Build succeeded |
Signed-off-by: Daniel Egger daniel@eggers-club.de