Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update flake.lock and flake.nix #145

Closed
wants to merge 1 commit into from

Conversation

mtul0729
Copy link

@mtul0729 mtul0729 commented Jun 1, 2024

This commit updates the flake.lock and flake.nix files. The flake.lock file now includes updated hashes and revision information for the dependencies "crane", "flake-utils", "nixpkgs", and "systems". The flake.nix file has been modified to include new URLs and inputs for the dependencies "crane", "rust-overlay", and "flake-utils". Additionally, the code has been modernized and the devShells.default and devShells.lock sections have been updated.

This commit updates the flake.lock and flake.nix files. The flake.lock file now includes updated hashes and revision information for the dependencies "crane", "flake-utils", "nixpkgs", and "systems". The flake.nix file has been modified to include new URLs and inputs for the dependencies "crane", "rust-overlay", and "flake-utils". Additionally, the code has been modernized and the devShells.default and devShells.lock sections have been updated.
@mtul0729 mtul0729 requested a review from a team as a code owner June 1, 2024 08:10
@mtul0729 mtul0729 closed this Jun 1, 2024
@mtul0729 mtul0729 reopened this Jun 1, 2024
@Emilgardis
Copy link
Member

I fail to see how this is an update when it actually adds these files! It also adds Cargo.lock. We've had discussions about this before, see #103, but I personally think it's time for us to add Cargo.lock since the format has changed and it's now even recommended by the cargo team to check it out in binaries

@Emilgardis
Copy link
Member

Emilgardis commented Jun 1, 2024

I'm not familiar with flake.nix, why would we need it? I fail to see the reason to include it in repo, since we don't have any dependency on it

@mtul0729 mtul0729 closed this Jun 10, 2024
@mtul0729 mtul0729 deleted the flake branch June 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants