Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for the Modifiers struct to Keyboard #40

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

iTitus
Copy link
Contributor

@iTitus iTitus commented Sep 10, 2023

Closes #39

src/lib.rs Outdated Show resolved Hide resolved
@thejpster
Copy link
Member

Please run cargo fmt and squash the change into the last commit. Thank you!

@iTitus
Copy link
Contributor Author

iTitus commented Sep 11, 2023

@iTitus iTitus requested a review from thejpster September 11, 2023 11:15
@thejpster
Copy link
Member

Yes, I am aware how Github works.

My default position is that any proposed set of git commits should form a reasonable and understandable set of changes. Formatting should be squashed into whichever commit changed the line that broke the formatting check. In this case, there is only one change and I am happy to squash it for you.

@thejpster thejpster merged commit 4aa5ef6 into rust-embedded-community:main Sep 11, 2023
@iTitus iTitus deleted the open-modifiers branch September 11, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Open up the API to allow access to the internal Modifiers struct from Keyboard
2 participants