Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building macOS universal2 binaries/libraries #86

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Add support for building macOS universal2 binaries/libraries #86

merged 3 commits into from
Feb 10, 2023
+244 −32

Conversation

messense
Copy link
Member

@messense messense commented Feb 10, 2023 •
edited
Loading

Note that cargo install only accepts one --target so I choose to not add universal2 support for cargo-zigbuild install command.

@messense messense enabled auto-merge February 10, 2023 09:41
@messense messense disabled auto-merge February 10, 2023 09:41
@messense messense enabled auto-merge February 10, 2023 09:41
@messense messense temporarily deployed to Docker Hub February 10, 2023 09:44 — with GitHub Actions Inactive
@messense messense added this pull request to the merge queue Feb 10, 2023
@messense messense removed this pull request from the merge queue due to a manual request Feb 10, 2023
@messense messense merged commit af319c7 into main Feb 10, 2023
@messense messense deleted the universal2 branch February 10, 2023 10:16
@messense messense changed the title Add support building macOS universal2 binaries/libraries Add support for building macOS universal2 binaries/libraries Feb 10, 2023
@yisibl
Copy link

yisibl commented Feb 10, 2023

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @yisibl