Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a macro to generate cargo commands #54

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

jaysonsantos
Copy link
Contributor

this was going to be an issue to support commands like clippy but, I tried to give it a go to see how it works.
I'd say it is pretty much a work in progress, but I wanted to check out with you folks if it is something worth pursuing.

@messense
Copy link
Member

Thanks, definitely looks promising.

@jaysonsantos
Copy link
Contributor Author

@messense I think it is ready for review :D

@jaysonsantos jaysonsantos force-pushed the experimental-macro branch 3 times, most recently from 379854d to 32d1011 Compare June 29, 2023 07:35
@messense
Copy link
Member

We need to upgrade proc-macro2 to fix the test, see rust-lang/rust#113152.

@messense
Copy link
Member

Please rebase and try again, I think I've fixed the nightly compiler issue in a9f18e1, thanks!

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 92ea4f7 into rust-cross:main Jun 30, 2023
@jaysonsantos jaysonsantos deleted the experimental-macro branch July 1, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants