Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #36

Closed
wants to merge 1 commit into from
Closed

Update deps #36

wants to merge 1 commit into from

Conversation

JoNil
Copy link
Contributor

@JoNil JoNil commented Aug 31, 2020

No description provided.

@parasyte
Copy link
Collaborator

parasyte commented Sep 1, 2020

We can't use cargo-xbuild = "0.6" until we update the pinned version of rustc. See rust-osdev/cargo-xbuild#88 (comment)

The rustc version is specified in

nightly-2020-05-15
and also makes an appearance in
- nightly-2020-02-16
(but the version here is outdated)

Copy link
Collaborator

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! We'll need to fix the CI failures (rustc needs to be updated). I'm not sure if that will be easy or not. Last time I updated was effortless. As long as CI passes, this will be good to go!

cargo-xbuild = "0.5"
colored = "1.9"
cargo-xbuild = "0.6"
colored = "2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, please use 2.0

Suggested change
colored = "2"
colored = "2.0"

parasyte added a commit that referenced this pull request Dec 27, 2020
@parasyte parasyte mentioned this pull request Dec 27, 2020
@parasyte parasyte closed this in #38 Dec 27, 2020
parasyte added a commit that referenced this pull request Dec 27, 2020
* Update dependencies

- Closes #36

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants