Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ci to github actions #164

Merged
merged 4 commits into from
Jul 18, 2020
Merged

move ci to github actions #164

merged 4 commits into from
Jul 18, 2020

Conversation

mainrs
Copy link
Contributor

@mainrs mainrs commented Jul 12, 2020

This adds a first draft of a GitHub Actions workflow that does some basic checks on PRs:

  • Run rustfmt
  • Run clippy
  • Run check on all available Rust versions (beta, nightly, stable) + MSRV of 1.31.0
  • Run ci crate and example

Relies on #165 to successfully run CI.

Edit: I am not sure how to actually test run this, I will probably just create a dummy PR on my fork and report back once they run successfully.

Edit 2: I created a (really ugly) PR on my fork at https://github.com/SirWindfield/env_logger/pull/3/. All checks pass except the lint, which is expected.

@mainrs
Copy link
Contributor Author

mainrs commented Jul 12, 2020

Ok, so it all works. There is some stuff I want to point out though:

  1. Clippy runs against nightly and not 1.31.0, meaning that it picks up lints that are currently not supported on 1.31.0 (like #[non_exhaustive]). This should be changed, shouldn't it?
  2. Documentation is currently not published to github pages. Not sure if this is actually needed or not. I do think a workflow that listens for tag pushes and automatically publishes to crates.io is more beneficial here.

@mainrs mainrs mentioned this pull request Jul 12, 2020
8 tasks
@KodrAus
Copy link
Collaborator

KodrAus commented Jul 12, 2020

Thanks @sirwindfield! This looks great to me. I think for clippy running against nightly is ok, because we should be able to #[allow(clippy::lint)] without producing warnings on channels that we can't implement the lint for. What do you think?

@mainrs
Copy link
Contributor Author

mainrs commented Jul 12, 2020

Sounds like a good plan. We can fix those later on if the MSRV is bumped up :)

I'd however like to open up an issue for adding a cd workflow as well to make publishing the crate a little bit more automated :)
Done.

1.41.0 is the version currently used on Ubuntu LTS releases.
@mainrs mainrs marked this pull request as ready for review July 12, 2020 22:17
Copy link
Collaborator

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@KodrAus KodrAus merged commit 95465b2 into rust-cli:master Jul 18, 2020
@mainrs mainrs deleted the github_actions branch July 18, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants