-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ci to github actions #164
Conversation
Ok, so it all works. There is some stuff I want to point out though:
|
Thanks @sirwindfield! This looks great to me. I think for |
Sounds like a good plan. We can fix those later on if the MSRV is bumped up :)
|
1.41.0 is the version currently used on Ubuntu LTS releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
This adds a first draft of a GitHub Actions workflow that does some basic checks on PRs:
ci
crate and exampleRelies on #165 to successfully run CI.
Edit: I am not sure how to actually test run this, I will probably just create a dummy PR on my fork and report back once they run successfully.
Edit 2: I created a (really ugly) PR on my fork at https://github.com/SirWindfield/env_logger/pull/3/. All checks pass except the lint, which is expected.