Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteStyle is ignored when used with Target::Pipe #274

Closed
miraclx opened this issue Aug 9, 2023 · 0 comments · Fixed by #298 or #302
Closed

WriteStyle is ignored when used with Target::Pipe #274

miraclx opened this issue Aug 9, 2023 · 0 comments · Fixed by #298 or #302
Milestone
0.11

Comments

@miraclx
Copy link

miraclx commented Aug 9, 2023

The patch #239, while addressing issue #208 made it so we can write to a custom sink without being in a test context.

The unfortunate downside of that implementation is it disregards the WriteStyle specification.

No colors when piping to a custom sink is an acceptable default, but when the user specifies WriteStyle::Always, we should have colors written into our sink.
@miraclx miraclx mentioned this issue Aug 9, 2023
Closed
@epage epage added this to the 0.11 milestone Nov 10, 2023
epage added a commit to epage/env_logger that referenced this issue Jan 18, 2024
@epage
fix(fmt): Allow styling on the Pipe
a98dadb 
Fixes rust-cli#274
epage added a commit to epage/env_logger that referenced this issue Jan 18, 2024
@epage
fix(fmt): Allow styling on the Pipe
1ffb559 
Fixes rust-cli#274
@epage epage mentioned this issue Jan 18, 2024
Merged
epage added a commit to epage/env_logger that referenced this issue Jan 18, 2024
@epage
fix(fmt): Allow styling on the Pipe
4e04ec7 
Fixes rust-cli#274
epage added a commit to epage/env_logger that referenced this issue Jan 18, 2024
@epage
fix(fmt): Allow styling on the Pipe
730b0a0 
Fixes rust-cli#274
@Bobo1239 Bobo1239 mentioned this issue Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
2 participants
@epage @miraclx