Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call reduce0 from reduce1 and 2 #643

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

RCasatta
Copy link
Contributor

reduce code duplication by calling the function that provide the same check and side effects

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5c48516 neat!

@RCasatta RCasatta closed this Feb 26, 2024
@apoelstra apoelstra merged commit 666918f into rust-bitcoin:master Feb 26, 2024
11 of 16 checks passed
apoelstra added a commit to ElementsProject/elements-miniscript that referenced this pull request Mar 4, 2024
085129f call reduce0 from reduce1/2 (Riccardo Casatta)

Pull request description:

  once the terminal is wrapped it does the same checks and produce the same side effects

  same as rust-bitcoin/rust-miniscript#643

ACKs for top commit:
  apoelstra:
    ACK 085129f

Tree-SHA512: 55ee7bdb5bbf3419808c5e0ab2d232feba6b91256e5ae11736726737d0fbb2c1cdfaa6df796c8cfbc3c81265eddeb83ddd9571f1a8e062a8fc8fcfea3bb13c0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants