Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependency on ordering crate #190

Closed
wants to merge 1 commit into from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jul 31, 2024

Add an optional dependency on the ordering crate and implement ArbitraryOrd for Fe32 if the feature is enabled.

@tcharding
Copy link
Member Author

Requested by lightningdevkit/rust-lightning#3195

@tcharding
Copy link
Member Author

Something is wrong with the check api script, @apoelstra now that we removed it in rust-bitcoin what is your thoughts, are we removing it everywhere?

@apoelstra
Copy link
Member

Yeah, let's remove it everywhere. These constant breakages I think are unacceptable given the way we were trying to use it. I also never got it to work with my local CI so we never really integrated it that well.

@apoelstra
Copy link
Member

utACK a8ceeb6 but the check-API commit should be changed to just remove the script.

@tcharding tcharding marked this pull request as draft July 31, 2024 19:18
@tcharding tcharding force-pushed the 07-31-arbitrary-ord branch 2 times, most recently from 523b6c6 to e7bcc93 Compare August 1, 2024 12:26
@tcharding
Copy link
Member Author

the check-API commit should be changed to just remove the script.

I don't understand this comment, I've rebased on #192 so that CI passes. If #192 is not right lets discuss it over there.

Add an optional dependency on the `ordering` crate and implement
`ArbitraryOrd` for `Fe32` if the feature is enabled.
@tcharding
Copy link
Member Author

Rebase only, no code changes.

@tcharding tcharding marked this pull request as ready for review August 6, 2024 22:32
@apoelstra
Copy link
Member

FWIW I'm increasingly skeptical of this. It's not clear that anybody needs it and it increases our feature test matrix.

@tcharding
Copy link
Member Author

I'll close since you are looking into the rust-lightning upgrade to use bech32 v0.11.0 and that is what this was for.

@tcharding tcharding closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants