Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt: Use show_parse_errors #188

Merged
merged 1 commit into from
Jul 22, 2024
Merged

rustfmt: Use show_parse_errors #188

merged 1 commit into from
Jul 22, 2024

Conversation

jamillambert
Copy link
Contributor

@jamillambert jamillambert commented Jul 18, 2024 •
edited by apoelstra
Loading

Following on from the comment in rust-bitcoin #3006,
Quoting tcharding (link removed to prevent spamming rustfmt PR):

There are no behaviour changes with this patch applied.

In rust-lang/rustfmt 5961 the hide_parse_errors was changed to show_parse_errors with default true.

Since we run the formatter with nightly we are getting the following warning

Warning: the hide_parse_errors option is deprecated. Use show_parse_errors instead

Rename the variable and keep the default value true.

@jamillambert
rustfmt: Use show_parse_errors
77a5d0e 
In rust-lang/rustfmt `hide_parse_errors` was changed to
`show_parse_errors`

Rename the variable and keep the default value `true`.
tcharding
tcharding approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 77a5d0e

clarkmoody
clarkmoody approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 77a5d0e

apoelstra
apoelstra approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 77a5d0e

@apoelstra apoelstra merged commit 45bb227 into rust-bitcoin:master Jul 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@clarkmoody clarkmoody clarkmoody approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamillambert @apoelstra @clarkmoody @tcharding